[PATCH] D39927: [X86] Allow X86ISD::Wrapper to be folded into the base of gather/scatter address

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:1513
+  case X86ISD::Wrapper:
+    if (!matchWrapper(N, AM))
+      return false;
----------------
delena wrote:
> Do you have an example when the Wrapper is not matched?
I think right now the only way that can happen is if the codemodel is not small or kernel. Do you want me to add a test?


================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:1548
+    AM.Scale = 1;
+  } else {
+    if (matchVectorAddress(N, AM))
----------------
delena wrote:
> {} format
What's wrong with the formatting? Do you want the curly braces on the if removed? Or did you want me to merge the else and the "if (matchVectorAddress"


https://reviews.llvm.org/D39927