[PATCH] D39927: [X86] Allow X86ISD::Wrapper to be folded into the base of gather/scatter address
Elena Demikhovsky via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Nov 11 12:14:11 PST 2017
delena added inline comments.
================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:1513
+ case X86ISD::Wrapper:
+ if (!matchWrapper(N, AM))
+ return false;
----------------
Do you have an example when the Wrapper is not matched?
================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:1548
+ AM.Scale = 1;
+ } else {
+ if (matchVectorAddress(N, AM))
----------------
{} format
================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:1549
+ } else {
+ if (matchVectorAddress(N, AM))
+ return false;
----------------
Could you, please, add a comment that explains what does "matchVectorAddress" mean?
https://reviews.llvm.org/D39927
More information about the llvm-commits
mailing list