[PATCH] D39300: [SectionMemoryManager] Abstract out mmap, munmap, mprotect even more ; NFC

[Justin Lebar via Phabricator via llvm-commits]

jlebar accepted this revision.
jlebar added inline comments.


================
Comment at: include/llvm/ExecutionEngine/SectionMemoryManager.h:43
 public:
-  SectionMemoryManager() = default;
-  SectionMemoryManager(const SectionMemoryManager&) = delete;
-  void operator=(const SectionMemoryManager&) = delete;
+  /// This enum describes the various reason to allocate pages from
+  /// allocateMappedMemory.
----------------
reasons


================
Comment at: include/llvm/ExecutionEngine/SectionMemoryManager.h:56
+    /// This method attempts to allocate \p NumBytes bytes of virtual memory for
+    /// \p Purpose.  \p NearBlock may point to an existing allocation in which
+    /// case an attempt is made to allocate more memory near the existing block.
----------------
, in which case


https://reviews.llvm.org/D39300