[PATCH] D39300: [SectionMemoryManager] Abstract out mmap, munmap, mprotect even more ; NFC

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 8 10:39:38 PST 2017


asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: include/llvm/ExecutionEngine/SectionMemoryManager.h:73
+    /// \r a non-null MemoryBlock if the function was successful,
+    /// otherwise a null MemoryBlock is with \p EC describing the error.
+    virtual sys::MemoryBlock
----------------
Remove "is".


https://reviews.llvm.org/D39300





More information about the llvm-commits mailing list