Re: [PATCH] D39737: [MC] Fix regression tests on Windows when git “core.autocrlf” is set to true

[Zachary Turner via llvm-commits]

Not everyone is using git, so you will need a similar solution for SVN.
On Wed, Nov 8, 2017 at 7:26 AM Zhen Cao <zhen.cao at autodesk.com> wrote:

> Thanks Zachary. I agree with your concern, but I think adding the file
> “.gitattributes” that sets the test files as binary has the same effect as
> requiring “core.autocrlf=false”.
>
>
>
> *From:* Zachary Turner [mailto:zturner at google.com]
>
> *Sent:* Tuesday, November 7, 2017 5:58 PM
> *To:* reviews+D39737+public+a17c03644213de66 at reviews.llvm.org; Reid
> Kleckner via Phabricator <reviews at reviews.llvm.org>
> *Cc:* Zhen Cao <zhen.cao at autodesk.com>; grosbach at apple.com;
> bigcheesegs at gmail.com; javed.absar at arm.com; llvm-commits at lists.llvm.org
> *Subject:* Re: [PATCH] D39737: [MC] Fix regression tests on Windows when
> git “core.autocrlf” is set to true
>
>
>
> Honestly this is exactly the reason I think core.autocrlf=false should be
> required. A test whose correctness depends on a property of the source
> control system is broken. What if someone is using svn, not git? Now that
> needs a different solution
>
> On Tue, Nov 7, 2017 at 2:43 PM Reid Kleckner via Phabricator via
> llvm-commits <llvm-commits at lists.llvm.org> wrote:
>
> rnk added a comment.
>
> In https://reviews.llvm.org/D39737#918425
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D39737-23918425&d=DwMFaQ&c=76Q6Tcqc-t2x0ciWn7KFdCiqt6IQ7a_IF9uzNzd_2pA&r=5bO7zfHLitDTGEV53jsIoKY9YZM-dEXQXjvwmt4K1Xs&m=v1o3BA_P5gR207FWdrASaohpRGx5L9i-wllYLr0xnDA&s=1xaeIGYCdUSgYQ-ocHisoz8YM06hYvqy29UZbT5BPRE&e=>,
> @caoz wrote:
>
> > Thanks Reid. The fix doesn't have regressions on Linux, as it supports
> both styles of line ending ("\r\n" and "\n").
>
>
> I'm sure it's possible to add regression tests that run on Linux with
> .gitattributes.
>
>
> https://reviews.llvm.org/D39737
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D39737&d=DwMFaQ&c=76Q6Tcqc-t2x0ciWn7KFdCiqt6IQ7a_IF9uzNzd_2pA&r=5bO7zfHLitDTGEV53jsIoKY9YZM-dEXQXjvwmt4K1Xs&m=v1o3BA_P5gR207FWdrASaohpRGx5L9i-wllYLr0xnDA&s=B5SqFfLWfiZdVpOc55xf7lLW1XoZ2URLYHrnaXluv7k&e=>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> <https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwMFaQ&c=76Q6Tcqc-t2x0ciWn7KFdCiqt6IQ7a_IF9uzNzd_2pA&r=5bO7zfHLitDTGEV53jsIoKY9YZM-dEXQXjvwmt4K1Xs&m=v1o3BA_P5gR207FWdrASaohpRGx5L9i-wllYLr0xnDA&s=pdySAm6H_e5CeoeVyYzZwTvz59D_qeWeLSpgMC9X7QQ&e=>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171108/655fe026/attachment.html>