Not everyone is using git, so you will need a similar solution for SVN.<br><div class="gmail_quote"><div dir="ltr">On Wed, Nov 8, 2017 at 7:26 AM Zhen Cao <<a href="mailto:zhen.cao@autodesk.com">zhen.cao@autodesk.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">





<div lang="EN-US" link="blue" vlink="purple">
<div class="m_-2087109428522434312WordSection1">
<p class="MsoNormal">Thanks Zachary. I agree with your concern, but I think adding the file “.gitattributes” that sets the test files as binary has the same effect as requiring “core.autocrlf=false”.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"></p></div></div><div lang="EN-US" link="blue" vlink="purple"><div class="m_-2087109428522434312WordSection1"><p class="MsoNormal"><b>From:</b> Zachary Turner [mailto:<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>] <br>
</p></div></div><div lang="EN-US" link="blue" vlink="purple"><div class="m_-2087109428522434312WordSection1"><p class="MsoNormal"><b>Sent:</b> Tuesday, November 7, 2017 5:58 PM<br>
<b>To:</b> <a href="mailto:reviews%2BD39737%2Bpublic%2Ba17c03644213de66@reviews.llvm.org" target="_blank">reviews+D39737+public+a17c03644213de66@reviews.llvm.org</a>; Reid Kleckner via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>><br>
<b>Cc:</b> Zhen Cao <<a href="mailto:zhen.cao@autodesk.com" target="_blank">zhen.cao@autodesk.com</a>>; <a href="mailto:grosbach@apple.com" target="_blank">grosbach@apple.com</a>; <a href="mailto:bigcheesegs@gmail.com" target="_blank">bigcheesegs@gmail.com</a>; <a href="mailto:javed.absar@arm.com" target="_blank">javed.absar@arm.com</a>; <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<b>Subject:</b> Re: [PATCH] D39737: [MC] Fix regression tests on Windows when git “core.autocrlf” is set to true<u></u><u></u></p></div></div><div lang="EN-US" link="blue" vlink="purple"><div class="m_-2087109428522434312WordSection1">
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Honestly this is exactly the reason I think core.autocrlf=false should be required. A test whose correctness depends on a property of the source control system is broken. What if someone is using svn, not git? Now that needs a different
 solution <u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">On Tue, Nov 7, 2017 at 2:43 PM Reid Kleckner via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">rnk added a comment.<br>
<br>
In <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D39737-23918425&d=DwMFaQ&c=76Q6Tcqc-t2x0ciWn7KFdCiqt6IQ7a_IF9uzNzd_2pA&r=5bO7zfHLitDTGEV53jsIoKY9YZM-dEXQXjvwmt4K1Xs&m=v1o3BA_P5gR207FWdrASaohpRGx5L9i-wllYLr0xnDA&s=1xaeIGYCdUSgYQ-ocHisoz8YM06hYvqy29UZbT5BPRE&e=" target="_blank">
https://reviews.llvm.org/D39737#918425</a>, @caoz wrote:<br>
<br>
> Thanks Reid. The fix doesn't have regressions on Linux, as it supports both styles of line ending ("\r\n" and "\n").<br>
<br>
<br>
I'm sure it's possible to add regression tests that run on Linux with .gitattributes.<br>
<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D39737&d=DwMFaQ&c=76Q6Tcqc-t2x0ciWn7KFdCiqt6IQ7a_IF9uzNzd_2pA&r=5bO7zfHLitDTGEV53jsIoKY9YZM-dEXQXjvwmt4K1Xs&m=v1o3BA_P5gR207FWdrASaohpRGx5L9i-wllYLr0xnDA&s=B5SqFfLWfiZdVpOc55xf7lLW1XoZ2URLYHrnaXluv7k&e=" target="_blank">https://reviews.llvm.org/D39737</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwMFaQ&c=76Q6Tcqc-t2x0ciWn7KFdCiqt6IQ7a_IF9uzNzd_2pA&r=5bO7zfHLitDTGEV53jsIoKY9YZM-dEXQXjvwmt4K1Xs&m=v1o3BA_P5gR207FWdrASaohpRGx5L9i-wllYLr0xnDA&s=pdySAm6H_e5CeoeVyYzZwTvz59D_qeWeLSpgMC9X7QQ&e=" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</blockquote>
</div>
</div></div></blockquote></div>