[PATCH] D34393: [MC] Adding code padding for performance stability - infrastructure. NFC.

[Omer Paparo Bivas via Phabricator via llvm-commits]

opaparo marked 3 inline comments as done.
opaparo added inline comments.


================
Comment at: include/llvm/MC/MCCodePadder.h:24
+class MCObjectStreamer;
+class MCPaddingFragment;
+class MCSection;
----------------
gadi.haber wrote:
> MCPaddingFragment --> MCCodePaddingFragment ?
I actually don't want to limit the padding to code padding. My current implementation indeed pads with code (nops), but future implementation may pad in a different way.


================
Comment at: include/llvm/MC/MCCodePadder.h:216
+  virtual bool
+  basicBlockRequiresPaddingFragment(const MCCodePaddingContext &Context) const {
+    return false;
----------------
gadi.haber wrote:
> basicBlockRequiresPaddingFragment --> isBasicBlockRequiresPaddingFragment ?
This convention also exists in LLVM, I rather not change the name.


================
Comment at: include/llvm/MC/MCCodePadder.h:224
+  /// \returns true iff this policy needs padding for \p Inst.
+  virtual bool instructionRequiresPaddingFragment(const MCInst &Inst) const {
+    return false;
----------------
gadi.haber wrote:
> instructionRequiresPaddingFragment --> isInstructionRequiresPaddingFragment 
This convention also exists in LLVM, I rather not change the name.


https://reviews.llvm.org/D34393