[PATCH] D38714: [AVX512] Don't mark EXTLOAD as legal with AVX512. Continue using custom lowering.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:18438
+  // v8i8->v8i64.
+  if (Ext == ISD::EXTLOAD && !Subtarget.hasBWI() && RegVT == MVT::v8i64 &&
+      MemVT == MVT::v8i8)
----------------
delena wrote:
> Do we have a test for this case? 
Yes there were test cases that failed without this. I don't remember specifically which ones.


================
Comment at: test/CodeGen/X86/avx2-vbroadcast.ll:257
+; X32-NEXT:    movl {{[0-9]+}}(%esp), %eax
+; X32-NEXT:    vmovsd {{.*#+}} xmm0 = mem[0],zero
+; X32-NEXT:    vbroadcastsd %xmm0, %ymm0
----------------
Looks like there's still a folding problem here


https://reviews.llvm.org/D38714