[PATCH] D37458: [globalisel][tblgen] Add support for iPTR and implement am_unscaled* and am_indexed*

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h:259
+      if (SizeInBits == 0)
+        SizeInBits = State.MIs[InsnID]->getParent()->getParent()->getDataLayout().getPointerSizeInBits(0);
+
----------------
qcolombet wrote:
> Don't we have a more direct way to access the target from the selector?
> In particular something that doesn't depend on State.
> 
> (This is not wrong, it just looks weird.)
Not that I know of, but it would probably look better if I assigned it to an MF variable first.


https://reviews.llvm.org/D37458