[PATCH] D37458: [globalisel][tblgen] Add support for iPTR and implement am_unscaled* and am_indexed*

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Looks good modulo what I said in https://reviews.llvm.org/D37457 regarding GIM_CheckPointerToAny



================
Comment at: include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h:259
+      if (SizeInBits == 0)
+        SizeInBits = State.MIs[InsnID]->getParent()->getParent()->getDataLayout().getPointerSizeInBits(0);
+
----------------
Don't we have a more direct way to access the target from the selector?
In particular something that doesn't depend on State.

(This is not wrong, it just looks weird.)


================
Comment at: utils/TableGen/GlobalISelEmitter.cpp:977
+    if (!VTy.isMachineValueType())
+      return failedImport("unsupported typeset");
+
----------------
Looks like this part could be already independently committed.


https://reviews.llvm.org/D37458