[PATCH] D38021: [Compiler-rt][MIPS] Fix cross build for XRAY

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 9 16:35:27 PDT 2017


dberris added a comment.

In https://reviews.llvm.org/D38021#891881, @nitesh.jain wrote:

> >> SANITIZER_COMMON_CFLAGS is defined somewhere else in compiler-rt. It already should be including the CMAKE_C_FLAGS into its definition, so I'm confused why we even need this change.
>
> The CMAKE_C_FLAGS are not include in SANITIZER_COMMON_CFLAGS because of which cross-native build of x-ray is failing.


Okay, but can't you use CMAKE_CXX_FLAGS instead of CMAKE_C_FLAGS?

Other question is why CMAKE_C_FLAGS is important and special here.


https://reviews.llvm.org/D38021





More information about the llvm-commits mailing list