[PATCH] D38021: [Compiler-rt][MIPS] Fix cross build for XRAY

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added a comment.

In https://reviews.llvm.org/D38021#891819, @nitesh.jain wrote:

> Update diff as per suggestion


I think you misunderstood my suggestion.

`SANITIZER_COMMON_CFLAGS` is defined somewhere else in compiler-rt. It already should be including the `CMAKE_C_FLAGS` into its definition, so I'm confused why we even need this change.

I still don't understand what problem you're trying to solve with this patch.

Can you clearly describe what the problem is, and why this patch is supposed to fix the problem? Why isn't `CMAKE_CXX_FLAGS` sufficient? Also, if this is in a hosted build, why not just set the target architecture for the compiler-rt build directly?


https://reviews.llvm.org/D38021