[PATCH] D38160: [AArch64] Improve codegen for inverted overflow checking intrinsics

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls accepted this revision.
kristof.beyls added a comment.
This revision is now accepted and ready to land.

Thanks Amara, LGTM modulo one tiny nitpick which you should feel free to disagree with.



================
Comment at: test/CodeGen/AArch64/arm64-xaluo.ll:659-670
+; Check cc optimization of not(overflow)
+
+define i1 @saddo.not.i32(i32 %v1, i32 %v2) {
+entry:
+; CHECK-LABEL:  saddo.not.i32
+; CHECK:        cmn w0, w1
+; CHECK-NEXT:   cset w0, vc
----------------
Just one more tiny remark: I think it might be slightly easier to maintain this test file if the tests you added here we be each next to the "positive" test you copy pasted it from higher up in this file. E.g. moving saddo.not.i32 come right after saddo.select.i32.


Repository:
  rL LLVM

https://reviews.llvm.org/D38160