[PATCH] D38607: [AMDGPU] New 64 bit div/rem expansion

Javed Absar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 01:24:45 PDT 2017


javed.absar added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.cpp:1511
+
+  assert(VT == MVT::i64);
+
----------------
Maybe a good idea to put a contextual message along with your assert : 
e.g. assert(VT == EVT:i64 && "LowerUDIVREM64 expects a i64")
or something like that.


https://reviews.llvm.org/D38607





More information about the llvm-commits mailing list