[PATCH] D38607: [AMDGPU] New 64 bit div/rem expansion

Brian Sumner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 16:55:43 PDT 2017


b-sumner added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.cpp:1623
+
+    // if C3 != 0 ...
+    SDValue Sub2_Lo = DAG.getNode(ISD::SUBCARRY, DL, HalfCarryVT, Sub1_Lo,
----------------
It wouldn't hurt to have more comments expressing the algorithm in a C-like style.


https://reviews.llvm.org/D38607





More information about the llvm-commits mailing list