[PATCH] D38137: [ELF] Simpler scheme for handling common symbols

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks!



================
Comment at: ELF/MarkLive.cpp:221
   auto MarkSymbol = [&](SymbolBody *Sym) {
     if (auto *D = dyn_cast_or_null<DefinedRegular>(Sym)) {
       if (auto *IS = cast_or_null<InputSectionBase>(D->Section))
----------------
nit: remove {}


================
Comment at: ELF/Symbols.cpp:282
     : Defined(SymbolBody::DefinedCommonKind, Name, /*IsLocal=*/false, StOther,
               Type),
+      Alignment(Alignment), Size(Size) {}
----------------
bd1976llvm wrote:
> ruiu wrote:
> > I don't think this is how clang-format formats.
> I tried both the Windows and the Linux versions of the latest clang format. In both cases I got the same formatting. Am I doing something wrong? What do you expect the formatting to be here?
> 
> 
Oh sorry, then that's fine.


https://reviews.llvm.org/D38137