[PATCH] D38137: [ELF] Simpler scheme for handling common symbols

ben via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 28 09:35:17 PDT 2017


bd1976llvm marked an inline comment as done.
bd1976llvm added inline comments.


================
Comment at: ELF/Symbols.cpp:282
     : Defined(SymbolBody::DefinedCommonKind, Name, /*IsLocal=*/false, StOther,
               Type),
+      Alignment(Alignment), Size(Size) {}
----------------
ruiu wrote:
> I don't think this is how clang-format formats.
I tried both the Windows and the Linux versions of the latest clang format. In both cases I got the same formatting. Am I doing something wrong? What do you expect the formatting to be here?




https://reviews.llvm.org/D38137





More information about the llvm-commits mailing list