[PATCH] D38329: [llvm-objcopy] Fix latent bug that allowed some Sections to be improperly cast to StringTableSections

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 28 13:11:56 PDT 2017


jakehehrlich added a comment.

In https://reviews.llvm.org/D38329#883062, @jhenderson wrote:

> So, from what I can see, it is no longer a requirement for a dynamic section (or indeed any "SectionWithStrTab" instance) to refer to a section of type SHT_STRTAB? Is this desirable, because it sounds a bit odd to me? I could support a check in SectionWithStrtab::initialize that checks the actual type of the string table. Otherwise, this change looks reasonable to me.


I think a check is a good idea. In fact I thought I added that check; not sure why it didn't make it to review.


Repository:
  rL LLVM

https://reviews.llvm.org/D38329





More information about the llvm-commits mailing list