[PATCH] D34596: [X86]: Adding a new priority function 'guided-src' for Scheduler DAG instruction scheduling.

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

Sorry about this review stalling. To give at least some feedback:

- We generally want to phase out the SelectionDAG schedulers and only have them do a minimal amount of work. The actual scheduling should happen in the MachineScheduler. So ideally we would not add new features here. (That said I can see why you are doing it here: the MachineScheduler currently does not reorder flags producers/users)
- I believe none of the currently active LLVM developers is really familiar with the SelectionDAG schedulers.

I will try to find time for an actual review soon (otherwise please keep pinging).


https://reviews.llvm.org/D34596