[PATCH] D38252: [ARM] Fix SJLJ exception handling when manually chosen on a platform where it isn't default

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: lib/Target/ARM/ARMSubtarget.cpp:153-155
   UseSjLjEH = isTargetDarwin() && !isTargetWatchABI();
+  if (Options.ExceptionModel == ExceptionHandling::SjLj)
+    UseSjLjEH = true;
----------------
compnerd wrote:
> I think that I would prefer:
> 
>     UsesSjLjEH = (isTargetDarwin() && !isTargetWatchABI()) || Options.ExceptionModel == ExceptionHandling::SjLj;
Sounds good. Or perhaps even `UsesSjLjEH = (isTargetDarwin() && !isTargetWatchABI() && Options.ExceptionModel == ExceptionHandling::None) || Options.ExceptionModel == ExceptionHandling::SjLj;` to allow disabling it on iOS as well.


https://reviews.llvm.org/D38252