[PATCH] D38252: [ARM] Fix SJLJ exception handling when manually chosen on a platform where it isn't default

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Target/ARM/ARMSubtarget.cpp:153-155
   UseSjLjEH = isTargetDarwin() && !isTargetWatchABI();
+  if (Options.ExceptionModel == ExceptionHandling::SjLj)
+    UseSjLjEH = true;
----------------
I think that I would prefer:

    UsesSjLjEH = (isTargetDarwin() && !isTargetWatchABI()) || Options.ExceptionModel == ExceptionHandling::SjLj;


https://reviews.llvm.org/D38252