[PATCH] D38129: [ELF] - Speedup -r and --emit-relocs

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 26 15:30:55 PDT 2017


grimar added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:1358-1360
+  // Initialize symbol search table lazily. This is used only when -r or
+  // --emit-relocs is given and allows to find symbol table index without
+  // linear search what improves perfomance drastically in some cases.
----------------
ruiu wrote:
> is -> are
> allow to -> allow us to
> 
> Probably a better comment is just: Initializes a symbol lookup table lazily. This is used only for -r or -emit-relocs.
Used "Initializes a symbol lookup table**s** lazily. This is used only for -r or -emit-relocs.".


https://reviews.llvm.org/D38129





More information about the llvm-commits mailing list