[PATCH] D38230: [dsymutil] Better support for symbol aliases

[Frederic Riss via Phabricator via llvm-commits]

friss added inline comments.


================
Comment at: tools/dsymutil/MachODebugMapParser.cpp:389-395
+  if (ObjectSymIt == CurrentObjectAddresses.end()) {
+    for (const auto &Alias : getMainBinarySymbolNames(Value)) {
+      ObjectSymIt = CurrentObjectAddresses.find(Alias);
+      if (ObjectSymIt != CurrentObjectAddresses.end())
+        break;
+    }
+  }
----------------
I'm not sure I could construct a test case to trigger a bug here, but I think it would be safer to add as "Type != MachO::N_STSYM" condition to this if. I don't think it's possible to alias static symbols.


Repository:
  rL LLVM

https://reviews.llvm.org/D38230