[PATCH] D38230: [dsymutil] Better support for symbol aliases

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 09:02:23 PDT 2017


aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: tools/dsymutil/MachODebugMapParser.cpp:400
                    Twine(Name));
+  }
+
----------------
The LLVM style usually avoids bracing single statements.


================
Comment at: tools/dsymutil/MachODebugMapParser.cpp:450
+  std::vector<StringRef> Names;
+  for (auto It = MainBinarySymbolAddresses.begin(),
+            End = MainBinarySymbolAddresses.end();
----------------
range-based for?


Repository:
  rL LLVM

https://reviews.llvm.org/D38230





More information about the llvm-commits mailing list