[PATCH] D38174: [TableGen] Return StringRef from ValueTypeByHwMode::getMVTName
Krzysztof Parzyszek via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 22 08:00:52 PDT 2017
You were talking about replacing getAsString.
-Krzysztof
On 9/22/2017 9:30 AM, Zachary Turner wrote:
>
> On Fri, Sep 22, 2017 at 6:21 AM Krzysztof Parzyszek via Phabricator
> <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
>
> kparzysz accepted this revision.
> kparzysz added a comment.
> This revision is now accepted and ready to land.
>
> This is good regardless of any future changes to replace getAsString.
>
> Well, i was talking about replacing the function, in which case this
> change is just unnecessary churn. For debugging the function should be
> called dump()
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
More information about the llvm-commits
mailing list