[PATCH] D38174: [TableGen] Return StringRef from ValueTypeByHwMode::getMVTName

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 22 07:30:16 PDT 2017


On Fri, Sep 22, 2017 at 6:21 AM Krzysztof Parzyszek via Phabricator <
reviews at reviews.llvm.org> wrote:

> kparzysz accepted this revision.
> kparzysz added a comment.
> This revision is now accepted and ready to land.
>
> This is good regardless of any future changes to replace getAsString.

Well, i was talking about replacing the function, in which case this change
is just unnecessary churn.  For debugging the function should be called
dump()
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170922/7d111e22/attachment.html>


More information about the llvm-commits mailing list