[PATCH] D38054: [PowerPC] Fix the spill issue exposed by r310809

[Eric Christopher via Phabricator via llvm-commits]

echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D38054#877711, @hfinkel wrote:

> I think this generally looks fine.
>
> Just as a general note on code organizations and commenting, we seem to be accumulating a pretty deep call tree here of functions that only work correctly in 64-bit mode. Not in this patch, but we should do something about this (either segregating these things into a distinct part of the file and/or adding asserts and/or comments to the 64-bit-mode-only functions.


Agreed. Also a lot of the fine points of when to extend and when not could probably be split out as well. This is definitely getting pretty unwieldy.

-eric



================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:2979
     if (IsRHSZero)
       return getCompoundZeroComparisonInGPR(LHS, dl, ZeroCompare::LESExt);
+
----------------
As a note I find the ZeroCompare enum to be fairly inscrutable. Perhaps document it and what each value is?


Repository:
  rL LLVM

https://reviews.llvm.org/D38054