[PATCH] D38054: [PowerPC] Fix the spill issue exposed by r310809

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 21 09:15:36 PDT 2017


hfinkel added a comment.

I think this generally looks fine.

Just as a general note on code organizations and commenting, we seem to be accumulating a pretty deep call tree here of functions that only work correctly in 64-bit mode. Not in this patch, but we should do something about this (either segregating these things into a distinct part of the file and/or adding asserts and/or comments to the 64-bit-mode-only functions.


Repository:
  rL LLVM

https://reviews.llvm.org/D38054





More information about the llvm-commits mailing list