[PATCH] D38146: [AArch64] Fix bug in store of vector 0 DAGCombine.

[Eli Friedman via Phabricator via llvm-commits]

efriedma accepted this revision.
efriedma added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:9463
+  }
+  SDValue SplatVal = DAG.getCopyFromReg(St.getChain(), DL, ZeroReg, ZeroVT);
   return splitStoreSplat(DAG, St, SplatVal, NumVecElts);
----------------
I think you can use the entry node as the chain operand, rather than the store's chain?


================
Comment at: test/CodeGen/AArch64/fastcc.ll:28
 ; CHECK-TAIL: bl func_stack8
-; CHECK-TAIL: sub sp, sp, #16
+; CHECK-TAIL: stp xzr, xzr, [sp, #-16]!
 
----------------
This is... interesting.  But looks correct.


https://reviews.llvm.org/D38146