[PATCH] D38115: [lit/Win] Check if a path was found before attempting to use it.

[Zachary Turner via llvm-commits]

Does this actually fix the bots? I'm concerned they'll fail anyway as a
result of not finding the tools
On Wed, Sep 20, 2017 at 6:27 PM David L. Jones via Phabricator <
reviews at reviews.llvm.org> wrote:

> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL313854: [lit/Win] Check if a path was found before
> attempting to use it. (authored by dlj).
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D38115
>
> Files:
>   llvm/trunk/utils/lit/lit/llvm/config.py
>
>
> Index: llvm/trunk/utils/lit/lit/llvm/config.py
> ===================================================================
> --- llvm/trunk/utils/lit/lit/llvm/config.py
> +++ llvm/trunk/utils/lit/lit/llvm/config.py
> @@ -27,7 +27,8 @@
>              path = self.lit_config.getToolsPath(config.lit_tools_dir,
>                                             config.environment['PATH'],
>                                             ['cmp.exe', 'grep.exe',
> 'sed.exe'])
> -            self.with_environment('PATH', path, append_path=True)
> +            if path is not None:
> +                self.with_environment('PATH', path, append_path=True)
>              self.use_lit_shell = True
>
>          # Choose between lit's internal shell pipeline runner and a real
> shell.  If
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170921/e906fb4f/attachment.html>