Does this actually fix the bots?  I'm concerned they'll fail anyway as a result of not finding the tools<br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 20, 2017 at 6:27 PM David L. Jones via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL313854: [lit/Win] Check if a path was found before attempting to use it. (authored by dlj).<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D38115" rel="noreferrer" target="_blank">https://reviews.llvm.org/D38115</a><br>
<br>
Files:<br>
  llvm/trunk/utils/lit/lit/llvm/config.py<br>
<br>
<br>
Index: llvm/trunk/utils/lit/lit/llvm/config.py<br>
===================================================================<br>
--- llvm/trunk/utils/lit/lit/llvm/config.py<br>
+++ llvm/trunk/utils/lit/lit/llvm/config.py<br>
@@ -27,7 +27,8 @@<br>
             path = self.lit_config.getToolsPath(config.lit_tools_dir,<br>
                                            config.environment['PATH'],<br>
                                            ['cmp.exe', 'grep.exe', 'sed.exe'])<br>
-            self.with_environment('PATH', path, append_path=True)<br>
+            if path is not None:<br>
+                self.with_environment('PATH', path, append_path=True)<br>
             self.use_lit_shell = True<br>
<br>
         # Choose between lit's internal shell pipeline runner and a real shell.  If<br>
<br>
<br>
</blockquote></div>