[PATCH] D38002: Re-submit r289925 (Update .debug_line section version to match DWARF version)

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: lib/MC/MCDwarf.cpp:282-286
+  // FIXME: Right now the compiler doesn't support line table V5. Until it's
+  // supported keep generating line table V2, when Dwarf Info version V5 is used.  
+  if (LineTableVersion >= 5) 
+    LineTableVersion = 2; 
+  MCOS->EmitIntValue(LineTableVersion, 2);
----------------
That seems weird - why not LineTableVersion 4? (why would going from DWARF 4 to DWARF 5 make the line table version go from 4 to 2?)


Repository:
  rL LLVM

https://reviews.llvm.org/D38002