[PATCH] D38002: Re-submit r289925 (Update .debug_line section version to match DWARF version)

[Katya Romanova via Phabricator via llvm-commits]

kromanova created this revision.
Herald added subscribers: JDevlieghere, javed.absar, aprantl, emaste.

This is one more attempt to re-land patch r289925 that was reverted by Nico a while ago (because it caused problem for Chromium's symbolizer).

Nico filed a bug PR# 31407, https://bugs.llvm.org/show_bug.cgi?id=31407, but unfortunately, the reproducer was not created for several months. 
A couple of days ago Caroline confirmed that the problem was with the symbolizer, not with the patch itself. See all the details in PR# 31407.

So now I could re-submit the patch again.

I rebased my old patch (https://reviews.llvm.org/D16697) and made a few small changes. Namely, I updated debug_line table length/prologue length for some of newly added tests
and temporarily lowered the line table version to 2, when generation of DWARF V5 is requested (simply because line table V5 is not supported yet and a lot of newly added DWARF 5 tests started to fail).


Repository:
  rL LLVM

https://reviews.llvm.org/D38002

Files:
  lib/MC/MCDwarf.cpp
  test/CodeGen/X86/dbg-line-0-no-discriminator.ll
  test/DebugInfo/AArch64/line-header.ll
  test/DebugInfo/Generic/empty.ll
  test/DebugInfo/Generic/nodebug.ll
  test/DebugInfo/X86/empty.ll
  test/DebugInfo/X86/stmt-list-multiple-compile-units.ll
  test/MC/ELF/debug-line.s
  test/MC/ELF/debug-line2.s
  test/MC/ELF/debug-loc.s
  test/MC/ELF/discriminator.s
  test/MC/ELF/empty-dwarf-lines.s
  test/MC/MachO/file.s
  test/MC/MachO/gen-dwarf.s
  test/MC/MachO/loc.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38002.115731.patch
Type: text/x-patch
Size: 11559 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170918/3fd2bf7d/attachment.bin>