[PATCH] D36560: [llvm-objcopy] Add support for .dynamic, .dynsym, and .dynstr

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM with the suggested argument name changes.



================
Comment at: tools/llvm-objcopy/Object.cpp:381
+T *Object<ELFT>::getSectionOfType(uint16_t Index, Twine ErrMsg,
+                                  Twine CastErrMsg) {
+  if (T *TSec = llvm::dyn_cast<T>(getSection(Index, ErrMsg)))
----------------
The last argument name now needs changing both here and in the header. It may be wise to change ErrMsg as well to clearly disambiguate the two. Suggestions: ErrMsg -> IndexErrMsg; CastErrMsg -> TypeErrMsg.


Repository:
  rL LLVM

https://reviews.llvm.org/D36560