[PATCH] D37924: Add section headers to SpecialCaseLists

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich added inline comments.


================
Comment at: include/llvm/Support/SpecialCaseList.h:44
-// This is similar to the "ignore" feature of ThreadSanitizer.
-// http://code.google.com/p/data-race-test/wiki/ThreadSanitizerIgnores
 //
----------------
eugenis wrote:
> where did this comment go?
I deleted it because that link (1) has badly broken formatting that's not easy to understand and (2) seems to be long out-of-data anyways. `fun_r` and `fun_hist` don't seem to be supported by the current incarnation of TSan.


================
Comment at: lib/Support/SpecialCaseList.cpp:208
+  while (SectionsMap.begin() != SectionsMap.end())
+    SectionsMap.remove(&*SectionsMap.begin());
+
----------------
eugenis wrote:
> Is not that a memory leak? Who deallocates SectionEntries?
I thought I was correctly handling this but I'm not sure why on re-inspection. Fix incoming.


https://reviews.llvm.org/D37924