[PATCH] D37924: Add section headers to SpecialCaseLists

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 18 14:45:32 PDT 2017


eugenis added inline comments.


================
Comment at: include/llvm/Support/SpecialCaseList.h:44
-// This is similar to the "ignore" feature of ThreadSanitizer.
-// http://code.google.com/p/data-race-test/wiki/ThreadSanitizerIgnores
 //
----------------
where did this comment go?


================
Comment at: lib/Support/SpecialCaseList.cpp:208
+  while (SectionsMap.begin() != SectionsMap.end())
+    SectionsMap.remove(&*SectionsMap.begin());
+
----------------
Is not that a memory leak? Who deallocates SectionEntries?


https://reviews.llvm.org/D37924





More information about the llvm-commits mailing list