[PATCH] D37851: [Power9] Add missing Power9 instructions.

Tony Jiang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 18 14:25:31 PDT 2017


jtony marked 5 inline comments as done.
jtony added inline comments.


================
Comment at: lib/Target/PowerPC/PPCInstrInfo.td:3805
                      "mcrfs $BF, $BFA", IIC_BrMCR>;
+def SETB : XForm_44<31, 128, (outs g8rc:$RT), (ins crrc:$BFA),
+                     "setb $RT, $BFA", IIC_IntGeneral>;
----------------
nemanjai wrote:
> Do we not want 32-bit and 64-bit variants of these? If so, please stick to the naming convention of `<MNEMONIC>`/`<MNEMONIC>8` and set `Interpretation64Bit` accordingly. If they're 64-bit only, please move them to the right file and have them inherit `isPPC64`.
We just need 64 bit only, I will move them to PPCInstr64Bit.td


https://reviews.llvm.org/D37851





More information about the llvm-commits mailing list