[PATCH] D36560: [llvm-objcopy] Add support for .dynamic, .dynsym, and .dynstr
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 18 06:18:23 PDT 2017
jhenderson added inline comments.
================
Comment at: tools/llvm-objcopy/Object.cpp:397
+ // If a string table is allocated we don't want to mess with it. That would
+ // mean altering the memory image. There are no speical link types or
+ // anything so we can just use a Section.
----------------
speical -> special
================
Comment at: tools/llvm-objcopy/Object.h:210
+public:
+ DynamicSymbolTableSection(llvm::ArrayRef<uint8_t> Data) : SectionWithStrTab(Data) {}
+ static bool classof(const SectionBase *S) {
----------------
Has this been clang-formatted? The line looks a bit long.
================
Comment at: tools/llvm-objcopy/Object.h:243
+ template <class T>
+ T *getSectionCast(uint16_t Index, llvm::Twine ErrMsg, llvm::Twine CastErrMsg);
+
----------------
Not really important, but I'm not a massive fan of this name - maybe getSectionOfType?
Repository:
rL LLVM
https://reviews.llvm.org/D36560
More information about the llvm-commits
mailing list