[PATCH] D37957: [TableGen] Some simple optimizations to TableGen execution time

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 16 23:41:56 PDT 2017


craig.topper added inline comments.


================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.cpp:3110
     if (Pat->getNumTypes() != 0) {
-      std::string Types;
+      llvm::raw_svector_ostream OS(TypesString);
       for (unsigned k = 0, ke = Pat->getNumTypes(); k != ke; ++k) {
----------------
llvm:: shouldn't be necessary here.


================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.cpp:3800
 /// Dependent variable map for CodeGenDAGPattern variant generation
-typedef std::map<std::string, int> DepVarMap;
+typedef llvm::StringMap<int> DepVarMap;
 
----------------
Shouldn't need llvm::


https://reviews.llvm.org/D37957





More information about the llvm-commits mailing list