[PATCH] D37957: [TableGen] Some simple optimizations to TableGen execution time

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.h:81
 
-  std::string getAsString() const;
-  static std::string getAsString(const SetType &S);
+  llvm::raw_ostream &writeToStream(llvm::raw_ostream &OS) const;
+  static llvm::raw_ostream &writeToStream(const SetType &S,
----------------
I don't see any usage of the return value of this. Did I miss it?

If I didn't miss it, should this just be a void method called print? I think that would be consistent with other classes in LLVM.

Is the llvm:: namespace qualifier needed on raw_ostream?


https://reviews.llvm.org/D37957