[llvm] r313469 - Try to fix some failing bots.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 16 12:20:53 PDT 2017


Author: zturner
Date: Sat Sep 16 12:20:53 2017
New Revision: 313469

URL: http://llvm.org/viewvc/llvm-project?rev=313469&view=rev
Log:
Try to fix some failing bots.

It doesn't make sense to me why these bots are failing as the
traceback does not agree with the source code.  It's possible
something is stale or there is some other mysterious error,
but in any case hopefully this fixes it.

Modified:
    llvm/trunk/utils/lit/lit/llvm/config.py

Modified: llvm/trunk/utils/lit/lit/llvm/config.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/llvm/config.py?rev=313469&r1=313468&r2=313469&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/llvm/config.py (original)
+++ llvm/trunk/utils/lit/lit/llvm/config.py Sat Sep 16 12:20:53 2017
@@ -5,11 +5,6 @@ import sys
 
 import lit.util
 
-# Choose between lit's internal shell pipeline runner and a real shell.  If
-# LIT_USE_INTERNAL_SHELL is in the environment, we use that as an override.
-litshenv = os.environ.get("LIT_USE_INTERNAL_SHELL")
-litsh = lit.util.pythonize_bool(litshenv) if litshenv else (sys.platform == 'win32')
-
 def binary_feature(on, feature, off_prefix):
     return feature if on else off_prefix + feature
 
@@ -21,6 +16,7 @@ class LLVMConfig(object):
 
         features = config.available_features
 
+        self.use_lit_shell = False
         # Tweak PATH for Win32 to decide to use bash.exe or not.
         if sys.platform == 'win32':
             # For tests that require Windows to run.
@@ -31,8 +27,14 @@ class LLVMConfig(object):
                                            config.environment['PATH'],
                                            ['cmp.exe', 'grep.exe', 'sed.exe'])
             self.with_environment('PATH', path, append_path=True)
+            self.use_lit_shell = True
+
+        # Choose between lit's internal shell pipeline runner and a real shell.  If
+        # LIT_USE_INTERNAL_SHELL is in the environment, we use that as an override.
+        lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL")
+        if lit_shell_env:
+            self.use_lit_shell = lit.util.pythonize_bool(lit_shell_env)
 
-        self.use_lit_shell = litsh
         if not self.use_lit_shell:
             features.add('shell')
 




More information about the llvm-commits mailing list