[llvm] r313468 - [llvm-symbolizer] Fix coff-dwarf.test

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 16 12:01:05 PDT 2017


Author: zturner
Date: Sat Sep 16 12:01:04 2017
New Revision: 313468

URL: http://llvm.org/viewvc/llvm-project?rev=313468&view=rev
Log:
[llvm-symbolizer] Fix coff-dwarf.test

This was a bug in the test that was only exposed as a result of
refactoring some code in lit configuration files.  Previously,
llvm's lit configuration would only set the target-windows feature
if the system was also windows.  Since cross-compilation is
a thing, this isn't correct.  target-windows should be set
independently of system-windows.

Adding to that bug, this particular test then checked for
target-windows when it really meant "can I call a certain API on
the host machine", which is what system-windows is for.

Ultimately, this test only works if *both* the target and host
are Windows, so I've updated the test to reflect that.

Modified:
    llvm/trunk/test/tools/llvm-symbolizer/coff-dwarf.test

Modified: llvm/trunk/test/tools/llvm-symbolizer/coff-dwarf.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-symbolizer/coff-dwarf.test?rev=313468&r1=313467&r2=313468&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-symbolizer/coff-dwarf.test (original)
+++ llvm/trunk/test/tools/llvm-symbolizer/coff-dwarf.test Sat Sep 16 12:01:04 2017
@@ -3,7 +3,7 @@ RUN:     | llvm-symbolizer --inlining --
 RUN:     | FileCheck %s
 
 This test relies on UnDecorateSymbolName, which is Windows-only.
-REQUIRES: target-windows
+REQUIRES: target-windows, system-windows
 
 ADDR: 0x5009
 ADDR: 0x5038




More information about the llvm-commits mailing list