[PATCH] D37460: [GVN] Prevent LoadPRE from hoisting across instructions that don't pass control flow to successors

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 21:08:01 PDT 2017


dberlin added inline comments.


================
Comment at: lib/Transforms/Scalar/GVN.cpp:2170
+           "Implicit control flow map broken?");
+    OrderedBasicBlock OBB(CurrentBlock);
+    if (OBB.dominates(It->second, CurInst))
----------------
Please use ordered instructions, which caches this, and invalidate it as needed.



https://reviews.llvm.org/D37460





More information about the llvm-commits mailing list