[PATCH] D36870: [libcxx] Add missing __cxa_deleted_virtual
Stephan Bergmann via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 15 00:59:43 PDT 2017
sberg added a comment.
In https://reviews.llvm.org/D36870#871740, @EricWF wrote:
> Because libc++ doesn't actually have any instances of deleted virtual functions within the library __cxa_deleted_vilrtual is never used, and hence never exported on Linux.
> We do, however, have pure virtual functions, so `__cxa_pure_virtual` is exported transitively. On Linux we don't use the explicit export lists, so this change didn't change the Linux ABI.
Ah, I see. Thanks.
> Do you need somebody to commit this for you?
No, as this has been abandoned in favour of https://reviews.llvm.org/D37830 anyway.
https://reviews.llvm.org/D36870
More information about the llvm-commits
mailing list