[PATCH] D36870: [libcxx] Add missing __cxa_deleted_virtual

Eric Fiselier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 00:48:59 PDT 2017


EricWF added a comment.

In https://reviews.llvm.org/D36870#871739, @sberg wrote:

> ...but I'm still curious as to why `lib/abi/x86_64-unknown-linux-gnu.abilist` should want to mention `__cxa_pure_virtual` but not `__cxa_deleted_virtual`


Because libc++ doesn't actually have any instances of deleted virtual functions within the library __cxa_deleted_vilrtual is never used, and hence never exported on Linux.
We do, however, have pure virtual functions, so `__cxa_pure_virtual` is exported transitively. On Linux we don't use the explicit export lists, so this change didn't change the Linux ABI.

Do you need somebody to commit this for you?


https://reviews.llvm.org/D36870





More information about the llvm-commits mailing list