[PATCH] D37615: [ELF] Implement the relocations of AVR for LLD

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Well, I found that this patch contains too much duplicate code in GNU bfd  (e.g. `(x & 0xfc07) | (((srel >> 1) << 3) & 0x3f8)`, which is odd by the way because of redundant right shift before left shift). These pieces of code are exactly the same including variable names. Please don't do that unless you know what you are doing (if that's the case, please mention it in the commit message). In general, you cannot reuse GPL'ed code to lld. You can use bfd linker to understand the AVR relocations, but your patch needs be of your own work. I think you need to rewrite the patch entirely.


Repository:
  rL LLVM

https://reviews.llvm.org/D37615