[PATCH] D37615: [ELF] Implement the relocations of AVR for LLD

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

There's still odd pieces of code there. For example, I don't know about how R_AVR_8_LO8 should be handled, but I can say that this piece of code is odd

  case R_AVR_8_LO8:
    write16le(Loc, SRel & 0xffffff);

because masking all but the least significant 24 bits before writing the least significant 16 bit doesn't make sense.

As I wrote before, could you please review your code yourself more carefully before sending it for another round of code review?


Repository:
  rL LLVM

https://reviews.llvm.org/D37615