[PATCH] D37771: llvm-dwarfdump: automatically dump both regular and .dwo variant of sections

[David Blaikie via llvm-commits]

On Wed, Sep 13, 2017 at 2:36 PM Paul Robinson via Phabricator <
reviews at reviews.llvm.org> wrote:

> probinson added inline comments.
>
>
> ================
> Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:243
> +  bool ExplicitDWO =
> +      Explicit && sys::path::extension(DObj->getFileName()) == ".dwo";
> +  auto shouldDumpDWO = [&](unsigned DIDT_Section, StringRef Section) {
> ----------------
> Hmmm now you are attaching a semantic significance to what is just a
> naming convention.  I don't think that's appropriate.
> We should not worry about what "kind" of file it is, just whether the
> sections exist or not.
>

This conflicts with Adrian's reasonable desire to print headers if they're
explicitly requested, even if they're empty - I think that's probably a
good thing, so the user doesn't get confused wondering if they spelled the
option correctly, etc?


>
>
> https://reviews.llvm.org/D37771
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170913/5c2d6cff/attachment.html>