[PATCH] D37735: [ELF] - Remove one of OutputSectionFactory::addInputSec().

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 05:32:37 PDT 2017


grimar updated this revision to Diff 115017.
grimar retitled this revision from "[ELF] - Combine two OutputSectionFactory::addInputSec()." to "[ELF] - Remove one of OutputSectionFactory::addInputSec().".
grimar edited the summary of this revision.
grimar added a comment.

After playing with code I "re-invented" nicest way: just leave everything as is and make one of `addInputSec`
to be static helper. That way public `addInputSec` becomes the only way to add input section and it is able to report
discarded sections early enough, what solves initial problem.


https://reviews.llvm.org/D37735

Files:
  ELF/OutputSections.cpp
  ELF/OutputSections.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37735.115017.patch
Type: text/x-patch
Size: 4582 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170913/eee35c75/attachment.bin>


More information about the llvm-commits mailing list