[PATCH] D37735: [ELF] - Combine two OutputSectionFactory::addInputSec().

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 17:07:28 PDT 2017

Previous message: [PATCH] D37735: [ELF] - Combine two OutputSectionFactory::addInputSec().
Next message: [PATCH] D37735: [ELF] - Remove one of OutputSectionFactory::addInputSec().
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

ruiu added a comment.

The new code is hard to understand due to a pointer to a pointer to something. I think you can do this without two levels of pointer indirection.


https://reviews.llvm.org/D37735

Previous message: [PATCH] D37735: [ELF] - Combine two OutputSectionFactory::addInputSec().
Next message: [PATCH] D37735: [ELF] - Remove one of OutputSectionFactory::addInputSec().
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list